This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Always request 1× and 2× sprite images for portability #12933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a offline region, we've previously only requested the sprite image for the specified resolution. This lead to offline packs not being usable on devices that have a different pixel ratio. We're now requesting both 1x and 2x sprites. Some devices use even higher or fractional pixel ratios. However, we only ever use 1x and 2x sprite images in our requests.
kkaefer
force-pushed
the
offline-download-retina-sprite
branch
from
a144a6a
to
bc8418b
Compare
friedbunny
added
the
needs changelog
|
To clarify, this doesn't change the sprites we are downloading when viewing a map in regular operation. It only requests both when creating an offline pack. This is necessary when creating an offline pack on one device, and transferring it to another device with a different pixel ratio. |
friedbunny
removed
needs changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a offline region, we've previously only requested the sprite image for the specified resolution. This lead to offline packs not being usable on devices that have a different pixel ratio. We're now requesting both 1× and 2× sprites. Some devices use even higher or fractional pixel ratios. However, we only ever use 1× and 2× sprite images in our requests.